Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix for multi-config generators #1891

Merged
merged 2 commits into from
Jul 5, 2023
Merged

cmake: fix for multi-config generators #1891

merged 2 commits into from
Jul 5, 2023

Conversation

apwojcik
Copy link
Collaborator

This is one of the PRs adding support for multi-config generators (such as MS Visual C++ or Ninja Multi-Config) to MIGraphX. The multi-config generators do not use CMake variables to configure a build. They use generator expressions instead.

This PR sets up the default build configurations for single and multi-config generators.

@apwojcik apwojcik requested a review from pfultz2 June 27, 2023 20:11
@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #1891 (c75c6c1) into develop (3f56688) will not change coverage.
The diff coverage is n/a.

❗ Current head c75c6c1 differs from pull request most recent head 2e91478. Consider uploading reports for the commit 2e91478 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1891   +/-   ##
========================================
  Coverage    91.39%   91.39%           
========================================
  Files          419      419           
  Lines        15542    15542           
========================================
  Hits         14204    14204           
  Misses        1338     1338

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Jun 28, 2023 •
edited
Loading

Test Batch Rate new
2e9147		 Rate old
3f5668		 Diff Compare
torchvision-resnet50 64 895.87 2,275.69 -60.63% 🔴
torchvision-resnet50_fp16 64 5,314.73 5,343.62 -0.54% ✅
torchvision-densenet121 32 1,126.20 1,533.90 -26.58% 🔴
torchvision-densenet121_fp16 32 3,277.57 3,342.29 -1.94% ✅
torchvision-inceptionv3 32 593.89 1,303.30 -54.43% 🔴
torchvision-inceptionv3_fp16 32 2,522.70 2,512.94 0.39% ✅
cadene-inceptionv4 16 329.96 653.09 -49.48% 🔴
cadene-resnext64x4 16 395.94 571.07 -30.67% 🔴
slim-mobilenet 64 7,130.67 7,207.61 -1.07% ✅
slim-nasnetalarge 64 159.99 215.62 -25.80% 🔴
slim-resnet50v2 64 1,089.88 2,452.97 -55.57% 🔴
bert-mrpc-onnx 8 719.43 718.37 0.15% ✅
bert-mrpc-tf 1 370.51 362.25 2.28% ✅
pytorch-examples-wlang-gru 1 301.53 316.85 -4.83% 🔴
pytorch-examples-wlang-lstm 1 314.60 325.12 -3.24% 🔴
torchvision-resnet50_1 1 92.03 334.67 -72.50% 🔴
torchvision-inceptionv3_1 1 129.12 183.19 -29.52% 🔴
cadene-dpn92_1 1 335.35 346.37 -3.18% 🔴
cadene-resnext101_1 1 237.13 220.53 7.53% 🔆
slim-vgg16_1 1 53.37 223.56 -76.13% 🔴
slim-mobilenet_1 1 1,509.67 1,460.26 3.38% 🔆
slim-inceptionv4_1 1 101.45 219.01 -53.68% 🔴
onnx-taau-downsample 1 315.71 321.29 -1.74% ✅
dlrm-criteoterabyte 1 21.45 21.64 -0.91% ✅
dlrm-criteoterabyte_fp16 1 39.86 40.53 -1.66% ✅
agentmodel 1 5,982.33 6,006.08 -0.40% ✅
unet_fp16 2 52.77 53.07 -0.55% ✅

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten merged commit edc4bf5 into develop Jul 5, 2023
11 checks passed
@causten causten deleted the multi_config_generator branch July 5, 2023 12:57
@pfultz2 pfultz2 mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfultz2 pfultz2 pfultz2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apwojcik @migraphx-bot @pfultz2 @causten